This project is read-only.
1

Closed

CSS Compression hangs on invalid comment line at EOF

description

I added the compression task to an existing project in CC.NET. While testing, I found that the MSBuild process would hang (and red-line the processor), on one particular CSS file. The offending lines were right at the end of the file:
 
.moreactions_applyfilter_reset
{
text-align: right;
}
 
 
/* end of moreactions_filter
 
Note the final line is lacking a closing "*/" for the comment. Once this was added, the file processed without hanging the processor.
 
While this was an invalid file, the routine would be more robust if the compressor caught and exposed the error.
Closed Jul 3, 2009 at 4:32 AM by purekrome
Thanks for the bug report. Current code works fine with this issue now. A unit test has also been provided to make sure this doesn't happen again.

comments